-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opening .obj #8
Comments
I would definitively not add Actually, I think that the current representation of the mesh data is the one that makes the most sense to expose in this package, as everything more specific should be specified in visualisation tools that can load |
Yeah you can do that, it just seems like a bit of a roundabout way of going about this. Also a lot of functions like |
either way it's not a huge problem given that we have methods like |
uhm, I see your point! |
probably
|
of the top of my head:
2, 3, 4 are implemented by default in vtkplotter Mesh ;) |
also this might be useful: https://github.com/nschloe/meshio |
So, maybe the most convenient path is the following: we temporarily add the optional vtkplotter dependency, have tests working for the operations that require it, and then try to purge it out without affecting the test results. |
Sounds good. I'd like to avoid large dependencies as far as possible (in the end we may have 10+ packages that need to be interoperable), but there's no reason not to have them now and try to remove later. |
sounds like we found an agreement, will close for now |
Hey everyone,
Currently
.obj
files with mesh data are opened and returns as triplets of vertices, faces and edges, which is not very useful.Given that meshes are used almost exclusively for visualisation (in brainrender) I'd suggest opening them with
vtkplotter.vtkio.load
, which returns an instance ofMesh
fromvtkplotter
which has loads of useful function. A lot of functionality currently in brainrender which will be moved to brainatlas-api relies on theMesh
class.An alternative would be to use meshpart, but to be honest I haven't used it too much, don't know how good it is.
The only downside I can see is that this will require adding
vtkplotter
to the requirements which comes with a bunch of dependencies of it's own. It doesn't cause problems in my experience but it does make the package less lightweight.What do people think?
The text was updated successfully, but these errors were encountered: