Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build wheel when building package #144

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Build wheel when building package #144

merged 1 commit into from
Mar 29, 2023

Conversation

dstansby
Copy link
Member

  • Use NI actions to build the package
  • Add the option to test package building in pull requests by labelling as "Test packaging". Very open to changing this label name if anyone can suggest something better!

@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (00f2de7) 85.26% compared to head (880681f) 85.26%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #144   +/-   ##
=======================================
  Coverage   85.26%   85.26%           
=======================================
  Files          11       11           
  Lines         536      536           
=======================================
  Hits          457      457           
  Misses         79       79

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dstansby dstansby added Test packaging Run the source distribution and wheel build action on a PR and removed Test packaging Run the source distribution and wheel build action on a PR labels Mar 20, 2023
@dstansby dstansby closed this Mar 23, 2023
@dstansby dstansby reopened this Mar 23, 2023
@dstansby dstansby marked this pull request as ready for review March 29, 2023 14:09
@dstansby dstansby requested a review from a team March 29, 2023 14:09
@dstansby dstansby mentioned this pull request Mar 29, 2023
Closed
alessandrofelder
alessandrofelder approved these changes Mar 29, 2023
View reviewed changes
Copy link
Member

@alessandrofelder alessandrofelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

All alternative label texts I can think of are too verbose.

@alessandrofelder alessandrofelder merged commit b6e955d into brainglobe:main Mar 29, 2023
@dstansby dstansby deleted the wheel-build branch March 29, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessandrofelder alessandrofelder alessandrofelder approved these changes

Assignees
No one assigned
Labels
Test packaging Run the source distribution and wheel build action on a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dstansby @alessandrofelder