Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import header from brainglobe-utils #33

Merged
merged 4 commits into from
Apr 12, 2024
Merged

Import header from brainglobe-utils #33

merged 4 commits into from
Apr 12, 2024

Conversation

K-Meech
Copy link
Contributor

@K-Meech K-Meech commented Apr 12, 2024

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
brainglobe-registration currently contains a copy of the html headers from brainglobe_utils

What does this PR do?
This PR imports the headers from brainglobe_utils and removes any duplicates in this repo.

References

For brainglobe/cellfinder#327

How has this PR been tested?

All tests pass locally.

Is this a breaking change?

No

Does this PR require an update to the documentation?

No

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality (unit & integration)
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@K-Meech K-Meech requested a review from a team April 12, 2024 14:33
@willGraham01
Copy link

We've seen this napari error before in brainreg: https://brainglobe.zulipchat.com/#narrow/stream/408839-dev-private/topic/.E2.9C.94.20Brainreg.20test.20failure/near/431276552

Though it was supposed to be fixed by napari/napari#6799 on napari's end, and it looks like someone in the last 3 days has commented on the PR.

@K-Meech
Copy link
Contributor Author

K-Meech commented Apr 12, 2024

Thanks @willGraham01 - I guess the fix just hasn't made it into a new napari release yet? I was getting around this locally by using pip install lxml_html_clean in my environment.

Copy link
Member

@IgorTatarnikov IgorTatarnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good! I'll merge this and open a PR to deal with the failing tests, and #32.

@IgorTatarnikov IgorTatarnikov merged commit ef2174d into main Apr 12, 2024
9 of 19 checks passed
@IgorTatarnikov IgorTatarnikov deleted the header branch April 12, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants