Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading data from Big Data Viewer #3

Merged
merged 30 commits into from
May 7, 2024
Merged

Conversation

IgorTatarnikov
Copy link
Member

@IgorTatarnikov IgorTatarnikov commented Apr 16, 2024

Before submitting a pull request (PR), please read the contributing guide.

Please fill out as much of this template as you can, but if you have any problems or questions, just leave a comment and we will help out :)

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
This PR allows loading data from h5 files produced by mesoSPIM.

What does this PR do?
Create a tile class:

  • This class holds the resolution pyramid and metadata pertaining to each tile, such as the position within the stitched image.
  • The initial position is set based on the stage coordinates provided by the mesoSPIM in the .h5_meta.txt file.

Create an ImageMosaic class:

  • This class will hold most of the logic for the package.
  • It will hold a list of Tile objects as well as paths to various files/file objects required for downstream operations.

Create a StitchingWidget class that serves as a napari plugin:

  • Downsampled data is passed to be displayed in napari.
  • The widget keeps a list of tile layers that it's working with to allow updating positions.

How has this PR been tested?

Tests have been written that try to cover most basic cases for the added code. This package will use test data in the form of a downsampled tiled acquisition of one brain. The test data is stored on GIN.

A full size example can be found on ceph at /ceph/neuroinformatics/neuroinformatics/igort/stitching_data/Brain2

Is this a breaking change?

No.

Does this PR require an update to the documentation?

Yes, docs have not been written at this time.

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality (unit & integration)
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

Copy link

codecov bot commented Apr 16, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@IgorTatarnikov IgorTatarnikov marked this pull request as ready for review April 16, 2024 13:46
Copy link
Member

@alessandrofelder alessandrofelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT this looks good.
Think all my minor comments are requests to document slightly more explicitly, to help code legibility when it's not as present in our heads :)

brainglobe_stitch/file_utils.py Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
brainglobe_stitch/file_utils.py Show resolved Hide resolved
brainglobe_stitch/file_utils.py Outdated Show resolved Hide resolved
brainglobe_stitch/image_mosaic.py Show resolved Hide resolved
brainglobe_stitch/stitching_widget.py Show resolved Hide resolved
brainglobe_stitch/stitching_widget.py Show resolved Hide resolved
tests/test_unit/conftest.py Outdated Show resolved Hide resolved
tests/test_unit/test_image_mosaic.py Show resolved Hide resolved
@IgorTatarnikov IgorTatarnikov merged commit 68f0d78 into main May 7, 2024
22 checks passed
@IgorTatarnikov IgorTatarnikov deleted the loading-data-from-h5 branch May 7, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants