Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update atlas api import with new name #86

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

alessandrofelder
Copy link
Member

@alessandrofelder alessandrofelder commented Mar 25, 2024

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
Workflows still had a remaining import for the atlas API using its old name.

What does this PR do?
Updates the import call from bg_atlasapi to brainglobe_atlasapi

References

Closes #85

How has this PR been tested?

CI should pass, but didn't before in #85

Is this a breaking change?

No

Does this PR require an update to the documentation?

No

Checklist:

  • The code has been tested locally - hoping to get away with just CI (here and on cellfinder) for this one-line change.
  • [n/a] Tests have been added to cover all new functionality (unit & integration)
  • [n/a] The documentation has been updated to reflect any changes
  • [n/a] The code has been formatted with pre-commit

@alessandrofelder alessandrofelder self-assigned this Mar 25, 2024
@alessandrofelder alessandrofelder requested a review from a team March 25, 2024 16:43
@alessandrofelder alessandrofelder marked this pull request as ready for review March 25, 2024 16:44
@alessandrofelder
Copy link
Member Author

Probably worth re-running jobs on https://github.com/brainglobe/cellfinder/actions/runs/8423214341 before merging this, just to double-check.

Copy link
Collaborator

@willGraham01 willGraham01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably worth re-running jobs on https://github.com/brainglobe/cellfinder/actions/runs/8423214341 before merging this, just to double-check.

The action will only checkout the HEAD of main in this repo, so the workflow will continue to fail until this PR gets merged. But the action is (theoretically) just running the test suite here, so everything should be OK.

Will leave the merge decision up to you.

@alessandrofelder alessandrofelder merged commit 72eb628 into main Mar 26, 2024
8 checks passed
@alessandrofelder alessandrofelder deleted the patch-atlasapi-import branch March 26, 2024 10:20
@alessandrofelder
Copy link
Member Author

(Just confirming brainmapper tests on cellfinder repo pass now this fix is in main ✅ )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG] brainmapper didn't receive the brainglobe-atlasapi update
2 participants