Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove entry point for cellfinder workflow #93

Merged
merged 4 commits into from
Apr 23, 2024

Conversation

sfmig
Copy link
Contributor

@sfmig sfmig commented Apr 22, 2024

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
We expect that the main way the workflows will be useful for users is as reference scripts that they can "copy-paste" and adapt to their workflows. Therefore for simplicity we agreed to remove the entry point for the cellfinder workflow script.

Related to #9

What does this PR do?
Removes the entry point to the cellfinder workflow script

References

Please reference any existing issues/PRs that relate to this PR.

How has this PR been tested?

We had smoke tests for the entry point before but these are removed in this PR.

Is this a breaking change?

No

Does this PR require an update to the documentation?

No

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality (unit & integration)
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.38%. Comparing base (34c8404) to head (61485e4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #93      +/-   ##
==========================================
- Coverage   79.43%   79.38%   -0.05%     
==========================================
  Files          18       18              
  Lines         924      917       -7     
==========================================
- Hits          734      728       -6     
+ Misses        190      189       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfmig sfmig marked this pull request as ready for review April 23, 2024 09:59
@alessandrofelder
Copy link
Member

Could you update the PR description somehow (even just a short sentence linking to a larger issue, which is only partially addressed by this PR) so our future selves remember why we did this, please?

@sfmig
Copy link
Contributor Author

sfmig commented Apr 23, 2024

yes sorry, I completely missed it!

@alessandrofelder alessandrofelder merged commit 0fd2e4f into main Apr 23, 2024
10 checks passed
@alessandrofelder alessandrofelder deleted the smg/remove-entry-point branch April 23, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants