Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache cellfinder model in CI #97

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Cache cellfinder model in CI #97

merged 1 commit into from
Apr 25, 2024

Conversation

sfmig
Copy link
Contributor

@sfmig sfmig commented Apr 23, 2024

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
We are inspecting why CI is slow (work in progress) and this seemed a low hanging fruit which may improve a bit our timings.

What does this PR do?
It adds a step in the CI workflow for tests, for caching the cellfinder model. This is implemented in cellfinder CI but not here.

References

Related to #65.

How has this PR been tested?

Please explain how any new code has been tested, and how you have ensured that no existing functionality has changed.

Is this a breaking change?

If this PR breaks any existing functionality, please explain how and why.

Does this PR require an update to the documentation?

If any features have changed, or have been added. Please explain how the documentation has been updated (and link to the associated PR). See here for details.

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality (unit & integration)
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.38%. Comparing base (0fd2e4f) to head (e8a3d08).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #97   +/-   ##
=======================================
  Coverage   79.38%   79.38%           
=======================================
  Files          18       18           
  Lines         917      917           
=======================================
  Hits          728      728           
  Misses        189      189           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfmig sfmig marked this pull request as ready for review April 25, 2024 11:58
@sfmig sfmig requested a review from a team April 25, 2024 11:58
@alessandrofelder alessandrofelder merged commit cd1079a into main Apr 25, 2024
10 checks passed
@alessandrofelder alessandrofelder deleted the smg/cache-tf-model branch April 25, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants