Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hemisphere bug in check_orientation #207

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Conversation

alessandrofelder
Copy link
Member

@alessandrofelder alessandrofelder commented Jun 25, 2024

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?

check_orientation gave false information when working with hemispheres

What does this PR do?

Ensures check_orientation info is displayed correctly when working with hemispheres, and adds a test for this too (the test(s) could be more exhaustive, but hopefully sufficient in their current state, given brainreg development beyond maintenance not on our roadmap at the moment)

References

Closes #200

How has this PR been tested?

  • manual inspection by @IgorTatarnikov and I
  • new test added
  • I have locally checked that the new test failed before I made the bugfix commit

Is this a breaking change?

No (apart from fixing faulty behaviour).

Does this PR require an update to the documentation?

Maybe we should specify better the point of view of the check_orientation, and understand that better in the first place - to be tackled in brainglobe/brainglobe.github.io#210

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality (unit & integration)
  • [ \ ] The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@alessandrofelder alessandrofelder changed the title add test for check_orientation bug Fix hemisphere bug in check_orientation Jun 25, 2024
@alessandrofelder alessandrofelder marked this pull request as ready for review June 26, 2024 08:19
Copy link
Member

@IgorTatarnikov IgorTatarnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@IgorTatarnikov IgorTatarnikov merged commit b6a22e5 into main Jun 26, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] "Check orientation" button in napari not consistent with registration results for hemisphere
2 participants