Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update how Qt is installed on CI #117

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Update how Qt is installed on CI #117

merged 1 commit into from
Nov 15, 2023

Conversation

alessandrofelder
Copy link
Member

@alessandrofelder alessandrofelder commented Nov 14, 2023

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?

pytest currently throws a fatal error, possibly related to Qt

What does this PR do?

Follows the approach to getting Qt on CI suggested on the napari zulip, and implemented in https://github.com/brainglobe/brainglobe-utils/pull/13/checks, in the hope that the tests run and pass again.

References

Closes #116

How has this PR been tested?

CI is now passing again

Is this a breaking change?

No.

Does this PR require an update to the documentation?

No

Checklist:

  • [na] The code has been tested locally
  • [na] Tests have been added to cover all new functionality (unit & integration)
  • [na] The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7551633) 97.44% compared to head (147da4c) 97.44%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #117   +/-   ##
=======================================
  Coverage   97.44%   97.44%           
=======================================
  Files           8        8           
  Lines         391      391           
=======================================
  Hits          381      381           
  Misses         10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@IgorTatarnikov IgorTatarnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@IgorTatarnikov IgorTatarnikov merged commit 33cf0ee into main Nov 15, 2023
12 checks passed
@alessandrofelder alessandrofelder deleted the update-ci-qt branch November 15, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG] update linter versions PR exposed test failures
2 participants