Import header from brainglobe-utils #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willGraham01
requested changes
Apr 12, 2024
There was a problem hiding this comment.
All good with the changes, but I'm surprised the check-manifest is passing given that brainrender_napari/resources/brainglobe.png no longer exists, yet is explicitly included in the MANIFEST.
Either way, could you remove it from the manifest since it no longer exists in the package? Just deleting the include line should be enough - I can't explicitly comment on an untouched file in the diff otherwise I'd of suggested this for you. Thanks 😄
|
No worries - I've removed it now! 😄 |
willGraham01
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
brainrender-naparicurrently contains a copy of the html headers frombrainglobe_utilsWhat does this PR do?
This PR imports the headers from
brainglobe_utilsand removes any duplicates in this repo.References
For brainglobe/cellfinder#327
How has this PR been tested?
All tests pass locally.
Is this a breaking change?
No
Does this PR require an update to the documentation?
No
Checklist: