Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codecov token #142

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Add codecov token #142

merged 1 commit into from
Apr 18, 2024

Conversation

K-Meech
Copy link
Contributor

@K-Meech K-Meech commented Apr 18, 2024

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
Codecov is currently complaining on all actions runs with: secret-codecov-token is not set. This will be required in the future.

What does this PR do?
This PR ensures test_and_deploy is using the codecov token, as recommended in the readme for the neuroinformatics unit test action

References

None

How has this PR been tested?

Hopefully codecov won't error on the github actions runs for this PR

Is this a breaking change?

No

Does this PR require an update to the documentation?

No

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality (unit & integration)
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@K-Meech K-Meech requested a review from a team April 18, 2024 10:52
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.99%. Comparing base (014f5c5) to head (092757f).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #142      +/-   ##
==========================================
- Coverage   98.06%   97.99%   -0.08%     
==========================================
  Files          11       10       -1     
  Lines         466      448      -18     
==========================================
- Hits          457      439      -18     
  Misses          9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@willGraham01 willGraham01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds CodeCov token... CodeCov complains that line is not covered by tests 🙃

@willGraham01 willGraham01 merged commit 70f751e into main Apr 18, 2024
11 of 12 checks passed
@willGraham01 willGraham01 deleted the codecov_token branch April 18, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants