Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug related to issue #293, amended tests to check in the future #296

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

IgorTatarnikov
Copy link
Member

Before submitting a pull request (PR), please read the contributing guide.

Description

What is this PR
Addresses #293, removes the z mirror and adds tests for this bug in the future.

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?

What does this PR do?

References

Closes #293

How has this PR been tested?

Tests added to check for this issue.

Is this a breaking change?

No

Does this PR require an update to the documentation?

No

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality (unit & integration)
  • The code has been formatted with pre-commit

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7d00370) 86.24% compared to head (a1c23fe) 86.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #296      +/-   ##
==========================================
- Coverage   86.24%   86.23%   -0.02%     
==========================================
  Files          26       26              
  Lines        1214     1213       -1     
==========================================
- Hits         1047     1046       -1     
  Misses        167      167              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IgorTatarnikov IgorTatarnikov marked this pull request as ready for review December 8, 2023 16:33
@alessandrofelder alessandrofelder merged commit 9bdbecf into main Dec 8, 2023
19 checks passed
@alessandrofelder alessandrofelder deleted the asymmetric-cells branch December 8, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Cell density (still) not working properly
2 participants