Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deep copy the volume transform #297

Merged
merged 2 commits into from
Dec 8, 2023
Merged

deep copy the volume transform #297

merged 2 commits into from
Dec 8, 2023

Conversation

alessandrofelder
Copy link
Member

@alessandrofelder alessandrofelder commented Dec 8, 2023

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
There's a small bug in the test_volumetric_data transformation.

References

Fixes #294

How has this PR been tested?

Only on CI, by re-enabling the relevant test through the GH UI.

Is this a breaking change?

No

Does this PR require an update to the documentation?

No

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality (unit & integration)
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

this is the default value in future vedo releases
@alessandrofelder alessandrofelder self-assigned this Dec 8, 2023
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7d00370) 86.24% compared to head (4c3b590) 86.24%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #297   +/-   ##
=======================================
  Coverage   86.24%   86.24%           
=======================================
  Files          26       26           
  Lines        1214     1214           
=======================================
  Hits         1047     1047           
  Misses        167      167           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IgorTatarnikov IgorTatarnikov marked this pull request as ready for review December 8, 2023 16:50
Copy link
Member

@IgorTatarnikov IgorTatarnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@IgorTatarnikov IgorTatarnikov merged commit 47f04f9 into main Dec 8, 2023
12 of 19 checks passed
@IgorTatarnikov IgorTatarnikov deleted the deep-copy-transform branch December 8, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

test_volumetric_data fails
2 participants