Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpinned h5py version #299

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Unpinned h5py version #299

merged 1 commit into from
Dec 11, 2023

Conversation

IgorTatarnikov
Copy link
Member

Before submitting a pull request (PR), please read the contributing guide.

Description

Compatiblity with MorphIO v3.3.7

  • Other

Why is this PR needed?
Windows tests were failing due to a MorphIO update.

What does this PR do?
Unpin h5py from <=3.9.0 to ensure the correct hdf5 version is installed.

Is this a breaking change?

No

Does this PR require an update to the documentation?

No

Checklist:

  • The code has been tested locally
  • The code has been formatted with pre-commit

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (47f04f9) 86.23% compared to head (6fec26f) 86.23%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #299   +/-   ##
=======================================
  Coverage   86.23%   86.23%           
=======================================
  Files          26       26           
  Lines        1213     1213           
=======================================
  Hits         1046     1046           
  Misses        167      167           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alessandrofelder alessandrofelder merged commit 235cb0f into main Dec 11, 2023
19 checks passed
@alessandrofelder alessandrofelder deleted the windows-h5-fix branch December 11, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants