Add explicit brainglobe-space dependency
#320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #320 +/- ##
==========================================
+ Coverage 86.31% 86.39% +0.08%
==========================================
Files 26 26
Lines 1213 1213
==========================================
+ Hits 1047 1048 +1
+ Misses 166 165 -1 ☔ View full report in Codecov by Sentry. |
This was referenced Jan 24, 2024
alessandrofelder
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See brainglobe/brainglobe-space#37
We also were not depending on
bg-spacein our pyproject but were saved by it's implicit fetch frommorphapi, but now we will depend onbrainglobe-spaceas an insurance.New version upon merging will be 2.1.5.
Currently we are experiencing #322 which is a blocker. Investigating.