Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How are prep_classification and prep_training different? #272

Closed
sfmig opened this issue Jul 21, 2023 · 1 comment · Fixed by #349
Closed

How are prep_classification and prep_training different? #272

sfmig opened this issue Jul 21, 2023 · 1 comment · Fixed by #349
Labels
cellfinder-core Issue concerns the core backend question Further information is requested

Comments

@sfmig
Copy link
Contributor

sfmig commented Jul 21, 2023

In a PR discussion with @alessandrofelder, we noticed these two functions seem to only vary in the order of their input parameters:

If both classification and training require the same setup, maybe we can combine them in one function and name it prep_tensorflow_and_model or similar?

@sfmig sfmig added the question Further information is requested label Jul 21, 2023
@adamltyson
Copy link
Member

Yep, no reason to have both of these. Should just check that they aren't used in cellfinder/cellfinder-napari.

@willGraham01 willGraham01 added the cellfinder-core Issue concerns the core backend label Jan 3, 2024
@willGraham01 willGraham01 transferred this issue from brainglobe/cellfinder-core Jan 3, 2024
@adamltyson adamltyson mentioned this issue Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cellfinder-core Issue concerns the core backend question Further information is requested
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants