Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] CI breaks with pytest v8.0.0 #368

Closed
willGraham01 opened this issue Feb 1, 2024 · 1 comment · Fixed by #369
Closed

[BUG] CI breaks with pytest v8.0.0 #368

willGraham01 opened this issue Feb 1, 2024 · 1 comment · Fixed by #369
Labels
bug Something isn't working

Comments

@willGraham01
Copy link
Collaborator

CI (specifically pytest) now fails in the setup phase since version 8 was released. This is likely due to the changes to the collection phase, although I haven't had time to delve into the details.

Regardless, the tests themselves are not failing - rather pytest is failing to setup the tests themselves.

Failing workflow: https://github.com/brainglobe/cellfinder/actions/runs/7740974117/job/21107107180

Pytest version 8 release notes: https://docs.pytest.org/en/latest/changelog.html

@willGraham01 willGraham01 added the bug Something isn't working label Feb 1, 2024
@willGraham01
Copy link
Collaborator Author

Seems we're not alone, the culprit is pytest-lazy-fixture: TvoroG/pytest-lazy-fixture#65

Since this tool hasn't seen an update in 2+ years, going to stage an update which no longer depends on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant