Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for migration #261

Merged
merged 5 commits into from
Dec 13, 2023
Merged

Prepare for migration #261

merged 5 commits into from
Dec 13, 2023

Conversation

willGraham01
Copy link
Collaborator

@willGraham01 willGraham01 commented Nov 15, 2023

See brainglobe/BrainGlobe#45

Prepares the CLI-cellfinder package for migration into brainglobe-workflows.

Note that we do not want to archive the repository, since we need it for when we merge in cellfinder-core and cellfinder-napari.

On merge, tag new release version so that the deprecation warning files through to PyPI.

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (e5f3b6c) 24.61% compared to head (d3a2d0b) 24.57%.

Files Patch % Lines
cellfinder/__init__.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #261      +/-   ##
==========================================
- Coverage   24.61%   24.57%   -0.04%     
==========================================
  Files          23       23              
  Lines        1235     1237       +2     
==========================================
  Hits          304      304              
- Misses        931      933       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willGraham01 willGraham01 requested a review from a team November 15, 2023 11:56
@willGraham01 willGraham01 marked this pull request as ready for review November 15, 2023 11:57
cellfinder/__init__.py Outdated Show resolved Hide resolved
Co-authored-by: Alessandro Felder <alessandrofelder@users.noreply.github.com>
@alessandrofelder alessandrofelder merged commit b813051 into main Dec 13, 2023
11 of 13 checks passed
@alessandrofelder alessandrofelder deleted the prepare-for-migration branch December 13, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants