Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a test for connect_four #385

Merged
merged 1 commit into from
Feb 19, 2024
Merged

add a test for connect_four #385

merged 1 commit into from
Feb 19, 2024

Conversation

alessandrofelder
Copy link
Member

@alessandrofelder alessandrofelder commented Feb 16, 2024

Description

What is this PR

  • Bug fix (partial)
  • Addition of a new feature
  • Other

Why is this PR needed?

We would like to prevent #383 to happen again.

What does this PR do?
Writes a test for connect_four that reproduces #383, so we know it's fixed once we fix it.
For now, the test is marked as XFAIL (expected to fail) - this test is the minimal example needed to justify why we need to use uint32 for the signal_array (for cases where we have >65535 - possibly temporary - struct_ids - see #386 )

I am reluctant to add assertions in the highly optimised part of the code, as this may affect performance.

References

A step on the way to closing #383.

How has this PR been tested?

The PR adds a well-documented test that was run locally.

Is this a breaking change?

No.

Does this PR require an update to the documentation?

No.

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality (unit & integration)
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@alessandrofelder alessandrofelder self-assigned this Feb 16, 2024
@alessandrofelder alessandrofelder marked this pull request as ready for review February 16, 2024 13:37
@alessandrofelder alessandrofelder requested a review from a team February 16, 2024 13:38
Copy link
Collaborator

@willGraham01 willGraham01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@willGraham01 willGraham01 merged commit e0fbbc4 into main Feb 19, 2024
14 checks passed
@willGraham01 willGraham01 deleted the test-connect_four branch February 19, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants