basic fix avoiding writing to package files #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessandrofelder
force-pushed
the
fix-custom-configs
branch
from
e64ac1a
to
3ed20c9
Compare
|
I am happy to adapt brainmapper to the new names and re-release once/if my suggested variable/function names in this PR have been approved by a reviewer, and make the related releases. |
willGraham01
approved these changes
Mar 27, 2024
This was referenced Apr 4, 2024
matham
added a commit
to matham/brainglobe-workflows
that referenced
this pull request
Apr 11, 2024
…uration_path. Changed in brainglobe/cellfinder#394.
Merged
7 tasks
IgorTatarnikov
pushed a commit
to brainglobe/brainglobe-workflows
that referenced
this pull request
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
Specifying a non-default model currently writes to package files (which is a bad idea in general, but in particular causes errors on shared systems like our local HPC).
What does this PR do?
User-specified model configuration files are written to user folder instead.
It also documents and renames some of the functions involved.
References
Closes #393
How has this PR been tested?
Existing tests pass.
Is this a breaking change?
No.
Does this PR require an update to the documentation?
No.
Checklist: