-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add draft brainrender-napari tutorial #55
Conversation
I've tried to follow the advice from diataxis.fr on tutorials for this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added some very nitpicky suggestions. I also think my suggestion for the admonition box broke the sequential numbering. Does putting everything as 1.
automatically create the numbering? I've never seen this.
Generally it would be cool to add three things:
- Some images showing the buttons to click, and what a successful outcome is.
- Some more details as to why. Things like "the default reference image is X, if you want to view the other reference image Y, do this..."
- A (short) docs page alongside the other tools, so we can continue the pattern of comprehensive docs, and a specific application tutorial.
Co-authored-by: Adam Tyson <code@adamltyson.com>
While I'm happy not to be too dogmatic about it, I would argue that this goes against what the diataxis framework suggests for tutorials
|
Yes (makes it easier to insert a step without having to re-enumerate all subsequent ones) |
Is this contrary to the diataxis framework? I'm not arguing we give them technical details that they don't need to carry out a task, I'm arguing that we should let them know what they're doing. If they aren't a zebrafish biologist, would they learn how to click a button, but not what the button does? |
Yes, I (and diataxis) would agree with this, I think. From my understanding, diataxis suggests for tutorials to give the learner as little room as possible to make their own decisions - they should be able to follow steps and they don't care (at first) why they are doing them, as long as they can achieve an example task. I've added some minimal explanations to the text now - more feedback welcome! |
Thanks a lot for the thorough review, @adamltyson - maybe have another look as I've changed quite a bit? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice. I left some v small stylistic suggestions.
Co-authored-by: Adam Tyson <code@adamltyson.com>
Description
What is this PR
Why is this PR needed?
brainrender-napari
is nearing an initial release, but we have no users docs.What does this PR do?
Add a basic tutorial for how to interact with the BG atlas api via napari.
References
Closes #54
Partially addresses brainglobe/brainrender-napari#52
How has this PR been tested?
Downloaded artefact of website looks reasonable to me.
Is this a breaking change?
no
Does this PR require an update to the documentation?
no
Checklist: