ENH: Improve issues to pages script #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jhlegarreta
commented
Nov 9, 2021
•
jhlegarreta
commented
- ENH: Improve issues to pages script encapsulation
- ENH: Allow the issues to pages script to accept parameters
- ENH: Move issues to pages script to dedicated folder
Improve issues to pages script encapsulation.
jhlegarreta
added
enhancement
Allow the issues to pages script to accept parameters. Document the purpose of the script.
Move issues to pages script to dedicated folder.
jhlegarreta
force-pushed
the
ImproveIssueToPagesScript
branch
from
2f975eb
to
d46594d
Compare
|
I tried using your fork's URL @Remi-Gau, and the changes do not break things/the script works as expected/as before. However, changing the URL match regex to match the section title in your issues ( As time permits, I plan to move the methods to another module and probably add a few test so that things are made robust. Hopefully to avoid the above kind of things to a given extent. |
jhlegarreta
force-pushed
the
ImproveIssueToPagesScript
branch
from
0136e7d
to
d46594d
Compare
Remi-Gau
approved these changes
Nov 11, 2021
There was a problem hiding this comment.
That looks good to me.
I will merge this now.
If the 💩 hits the fan later then we'll trouble shoot it there and then.
Thanks @jhlegarreta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.