fix(number prop on dots): number prop on dots works when thumbnails a… #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re supplied. If the number isnt supplied then the length of thumbnails are considered
| @@ -27,20 +27,26 @@ export default class CarouselDots extends Component { | |||
|
|
|||
| renderCarouselDots() { | |||
| if (this.props.thumbnails) { | |||
| return this.props.thumbnails.map((thumbnail, index) => ( | |||
There was a problem hiding this comment.
this could be done simpler:
const dotsLength = isNaN(this.props.number) ? this.props.thumbnails.length : this.props.number;
return this.props.thumbnails.slice(0, dotsLength).map((thumbnail, index) => (
piotr-s-brainhub
approved these changes
Sep 30, 2019
|
Thanks @udaypydi @Lukasz-pluszczewski what do you think about this PR? |
|
you have conflicts now |
|
Am I correct that these changes were already merged as apart of #126 ? |
|
could you reply? |
|
Yeah these changes are already merged in other PR. |
|
thanks @udaypydi so I'm closing this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…re supplied. If the number isnt supplied then the length of thumbnails are considered
package.json:versionhas been updated withnpm version patch(ormajor/minoras appropriate)@brainhubeu/react-carouselversion has been updated indocs-www/package.jsonto the same which is inpackage.json:version