attach listeners to parent element #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.node.ownerDocument.addEventListener('touchstart', this.simulateEvent, true); | ||
| this.node.ownerDocument.addEventListener('touchmove', this.simulateEvent, { passive: false }); | ||
| this.node.ownerDocument.addEventListener('touchend', this.simulateEvent, true); | ||
| this.node.parentElement.addEventListener('mousemove', this.onMouseMove, true); |
There was a problem hiding this comment.
thanks for this PR;
could you explain how this fixes the problem?
are you sure it's enough to add an event listener to only the parent element but not both to the parent element and the owner document?
There was a problem hiding this comment.
The owner document references window.document. Simulating events globaly can potentially break other libraries which depend on those events/listeners. In my case, it was when I was using google maps. Why would I simulate touch events in a global context which can overlap with other libs? I want to keep it as local as possible.
Reference: https://stackoverflow.com/questions/9845043/when-node-ownerdocument-is-not-window-document
piotr-s-brainhub
approved these changes
Nov 28, 2019
|
are you OK with this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
package.json:versionhas been updated withnpm version patch(ormajor/minoras appropriate)@brainhubeu/react-carouselversion has been updated indocs-www/package.jsonto the same which is inpackage.json:versionAttach listeners for simulated events to the carousel wrapper instead of window document