Feature/pr 522 teaarte feature 519 on slide click #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
return slide index
feature/519 onSlideClick prop
|
I checked this PR resolves the problem and doesn't break anything (desktop). |
teaarte
approved these changes
Jun 9, 2020
|
Unfortunately, I got negative feedback from my team about this PR. In some situations, there can be some problems with this callback. Currently, we're doing a refactor to enable creating custom plugins for the react-carousel so when it's ready, you could publish your plugin for that. Before that, you have to use your own fork. You can merge the main repo to your fork whenever you want in order to have the newest bug fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deployed to https://beghp.github.io/gh-pages-rc-9
Fixes #519
- [x] an issue linked to the PR