Skip to content

Commit

Permalink
Include typing_extensions in install_requires
Browse files Browse the repository at this point in the history
Without making Pottery depend on `typing_extensions`, Pottery fails to
install correctly.

Bug first reported here: #299

I used this as an example: https://github.com/tensorflow/tensorflow/blob/4a8d9cf405e5be8cf250f7fa141f2013f395b5fe/tensorflow/tools/pip_package/setup.py#L89

Thanks, @skieffer, for suggesting this fix.
  • Loading branch information
brainix committed Dec 27, 2020
1 parent 77f857e commit 430ea8f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions requirements-to-freeze.txt
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
# https://github.com/andymccurdy/redis-py/issues/1278
redis>=3.4.1
mmh3
typing_extensions

coverage
coveralls
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
],
keywords=pottery.__keywords__,
packages=find_packages(exclude=('contrib', 'docs', 'tests*')),
install_requires=('redis>=3.4.1', 'mmh3'),
install_requires=('redis>=3.4.1', 'mmh3', 'typing_extensions'),
extras_require={},
package_data={'pottery': ('py.typed',)},
data_files=tuple(),
Expand Down

0 comments on commit 430ea8f

Please sign in to comment.