Auto-release Redlock on instance destruction #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I got the idea from here: ionelmc/python-redis-lock#13
|
🐟 |
brainix
added a commit
that referenced
this pull request
Nov 23, 2020
This PR effectively reverts this one: #272 When I deployed this to production, I started seeing these tracebacks in the logs: rajiv.shah@RajivsMacBookPro spool % heroku run python3 manage.py renumber_popularity Running python3 manage.py renumber_popularity on ⬢ spool... up, run.4291 (Hobby) [2020-11-23 00:46:42,717] INFO in stooges: renumber_popularity() held redlock:popularity for 38 ms Exception ignored in: <function Redlock.__del__ at 0x7f5aa68db8b0> Traceback (most recent call last): File "/app/.heroku/python/lib/python3.9/site-packages/pottery/redlock.py", line 472, in __del__ self.__release() File "/app/.heroku/python/lib/python3.9/site-packages/pottery/redlock.py", line 409, in release futures.add(executor.submit(self.__release_master, master)) File "/app/.heroku/python/lib/python3.9/concurrent/futures/thread.py", line 163, in submit raise RuntimeError('cannot schedule new futures after ' RuntimeError: cannot schedule new futures after interpreter shutdown On second thought, the Redlock's timeout should be enough to preserve liveness; we don't need to also auto-release Redlock on instance destruction.
brainix
added a commit
that referenced
this pull request
Nov 23, 2020
This PR effectively reverts this one: #272 When I deployed this to production, I started seeing these tracebacks in the logs: rajiv.shah@RajivsMacBookPro spool % heroku run python3 manage.py renumber_popularity Running python3 manage.py renumber_popularity on ⬢ spool... up, run.4291 (Hobby) [2020-11-23 00:46:42,717] INFO in stooges: renumber_popularity() held redlock:popularity for 38 ms Exception ignored in: <function Redlock.__del__ at 0x7f5aa68db8b0> Traceback (most recent call last): File "/app/.heroku/python/lib/python3.9/site-packages/pottery/redlock.py", line 472, in __del__ self.__release() File "/app/.heroku/python/lib/python3.9/site-packages/pottery/redlock.py", line 409, in release futures.add(executor.submit(self.__release_master, master)) File "/app/.heroku/python/lib/python3.9/concurrent/futures/thread.py", line 163, in submit raise RuntimeError('cannot schedule new futures after ' RuntimeError: cannot schedule new futures after interpreter shutdown On second thought, the Redlock's timeout should be enough to preserve liveness; we don't need to also auto-release Redlock on instance destruction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got the idea from here: ionelmc/python-redis-lock#13