Remove type annotation stubs #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My type annotation stubs made it upstream! python/typeshed#4480 But then I had to install `types-redis` because running Mypy 0.901 gave me these error messages: ``` Running static type checks pottery/exceptions.py:22: error: Library stubs not installed for "redis" (or incompatible with Python 3.9) pottery/monkey.py:37: error: Library stubs not installed for "redis" (or incompatible with Python 3.9) pottery/base.py:45: error: Library stubs not installed for "redis" (or incompatible with Python 3.9) pottery/base.py:45: note: Hint: "python3 -m pip install types-redis" pottery/base.py:45: note: (or run "mypy --install-types" to install all missing stub packages) pottery/base.py:45: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports pottery/base.py:47: error: Library stubs not installed for "redis.client" (or incompatible with Python 3.9) pottery/set.py:28: error: Library stubs not installed for "redis" (or incompatible with Python 3.9) pottery/set.py:29: error: Library stubs not installed for "redis.client" (or incompatible with Python 3.9) pottery/redlock.py:52: error: Library stubs not installed for "redis" (or incompatible with Python 3.9) pottery/redlock.py:54: error: Library stubs not installed for "redis.client" (or incompatible with Python 3.9) pottery/nextid.py:37: error: Library stubs not installed for "redis" (or incompatible with Python 3.9) pottery/nextid.py:39: error: Library stubs not installed for "redis.client" (or incompatible with Python 3.9) pottery/list.py:30: error: Library stubs not installed for "redis" (or incompatible with Python 3.9) pottery/list.py:32: error: Library stubs not installed for "redis.client" (or incompatible with Python 3.9) pottery/hyper.py:25: error: Library stubs not installed for "redis" (or incompatible with Python 3.9) pottery/dict.py:31: error: Library stubs not installed for "redis" (or incompatible with Python 3.9) pottery/dict.py:32: error: Library stubs not installed for "redis.client" (or incompatible with Python 3.9) pottery/deque.py:25: error: Library stubs not installed for "redis" (or incompatible with Python 3.9) pottery/deque.py:26: error: Library stubs not installed for "redis.client" (or incompatible with Python 3.9) pottery/counter.py:30: error: Library stubs not installed for "redis.client" (or incompatible with Python 3.9) pottery/cache.py:36: error: Library stubs not installed for "redis" (or incompatible with Python 3.9) pottery/cache.py:37: error: Library stubs not installed for "redis.exceptions" (or incompatible with Python 3.9) Found 20 errors in 12 files (checked 18 source files) ```
|
🐟 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My type annotation stubs made it upstream!
python/typeshed#4480
But then I had to install
types-redisbecause running Mypy 0.901 gaveme these error messages: