Bugfix megreg #619
Merged
Bugfix megreg #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moo-Marc
reviewed
May 17, 2023
|
|
||
| % Do not allow shared channel for raw data files | ||
| if isShareChan && any(strcmpi({sInputs.FileType}, 'raw')) | ||
| bst_report('Error', sProcess, [], 'Raw files should not use shared channel as all projectors from pre-processing will be lost'); |
There was a problem hiding this comment.
more importantly: "as the interpolation for raw files is saved as a projector in individual channel files"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR originated from the forum question: https://neuroimage.usc.edu/forums/t//40145 and offline discussions with @Moo-Marc. These are the changes:
Do not allow to have a channel shared for raw files, as this action will delete all the previous projectors from those raw files
The
Projectorfield is removed from the average channel structure that is saved only using the options "shared channel" and "non-raw" files.