-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow TransactionGateway.Search to return more than 50 transactions. #206
Merged
leighmcculloch
merged 9 commits into
braintree-go:master
from
dsmcfarl:paginated_transaction_search
Mar 3, 2018
Merged
Allow TransactionGateway.Search to return more than 50 transactions. #206
leighmcculloch
merged 9 commits into
braintree-go:master
from
dsmcfarl:paginated_transaction_search
Mar 3, 2018
Commits on Jan 9, 2018
-
Allow TransactionGateway.Search to return more than 50 transactions.
What === Fetch the Ids for all search results then fetch the transaction details one page at a time. TransactionGateway.Search should be backwards compatible. The only difference being additional fields in TransactionSearchResult and more than 50 transactions in the Transaction field. Per https://developers.braintreepayments.com/reference/general/searching/search-results/java up to 20,000 transactions can be returned. Much of this work is based on the work by @rkulla: https://github.com/dailyburn/braintree-go/commit/d44aa131caad6055c0e4aac2f3a24450aa818c63 Why === The Braintree API only returns 50 transactions with all details at one time. To fetch all results from a query, the transaction ids must be fetched first, then the details can be fetched by specifying 50 ids per API call. This issue was first raised in braintree-go#112.
Configuration menu - View commit details
-
Copy full SHA for f8c56af - Browse repository at this point
Copy the full SHA f8c56afView commit details
Commits on Feb 17, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 81e6ad0 - Browse repository at this point
Copy the full SHA 81e6ad0View commit details
Commits on Feb 19, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 4ff8e46 - Browse repository at this point
Copy the full SHA 4ff8e46View commit details -
Configuration menu - View commit details
-
Copy full SHA for cfd0d22 - Browse repository at this point
Copy the full SHA cfd0d22View commit details
Commits on Mar 2, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 48c837c - Browse repository at this point
Copy the full SHA 48c837cView commit details -
Configuration menu - View commit details
-
Copy full SHA for e9b626f - Browse repository at this point
Copy the full SHA e9b626fView commit details -
Configuration menu - View commit details
-
Copy full SHA for d51182b - Browse repository at this point
Copy the full SHA d51182bView commit details -
Configuration menu - View commit details
-
Copy full SHA for e80120b - Browse repository at this point
Copy the full SHA e80120bView commit details
Commits on Mar 3, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 92ac712 - Browse repository at this point
Copy the full SHA 92ac712View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.