Add CustomerRequest #212
Merged
Add CustomerRequest #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What === Add CustomerRequest and change the CustomerGateway Create function to use the same patterns found in the official Braintree SDKs. Why === Not all the fields that are returned for a customer are valid to pass to Braintree when creating and updating customers. The official Braintree SDKs, and some of the other gateways in this SDK, have moved to the model of separating requests and responses. This is part of the continuing effort to bring this SDK inline with the official SDKs. Notes === This contains a breaking change. The object used to hold the parameters for the CustomerGateway's Create function has changed from Customer to CustomerRequest. This is to be consistent with the other SDKs and so that the request struct only contains fields that can be passed to Braintree which makes its use clearer.
leighmcculloch
force-pushed
the
customer-request
branch
from
0bd56d3
to
3e54b64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add CustomerRequest and change the CustomerGateway Create function to use
the same patterns found in the official Braintree SDKs.
Why
Not all the fields that are returned for a customer are valid to pass to
Braintree when creating and updating customers. The official Braintree
SDKs, and some of the other gateways in this SDK, have moved to the
model of separating requests and responses. This is part of the
continuing effort to bring this SDK inline with the official SDKs.
Notes
This contains a breaking change. The object used to hold the parameters
for the CustomerGateway's Create function has changed from Customer to
CustomerRequest. This is to be consistent with the other SDKs and so
that the request struct only contains fields that can be passed to
Braintree which makes its use clearer.
Related
#209