Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing permissions for Google Play Services disable BraintreeFragment #22

Closed
mrsasha opened this issue Feb 21, 2017 · 5 comments
Closed

Comments

@mrsasha
Copy link

mrsasha commented Feb 21, 2017

Hi,

we've gotten reports from some of our users that they get the com.braintreepayments.api.exceptions.GoogleApiClientException: Connection failed: 19 error when they try to use the Braintree drop-in in our app.

This is the [SERVICE_MISSING_PERMISSION error code](https://developers.google.com/android/reference/com/google/android/gms/common/ConnectionResult#SERVICE_MISSING_PERMISSION), and apparently it shows up because the users disabled some of the play services permissions, and for that reason, google api client listener throws an exception which gets propagated immediately and effectively renders the whole BraintreeFragment unusable. It looks like the situation described in this article.

But, since this check is used only to ascertain the availability (or not) of Android Pay, I would rather like that that would be the outcome i.e. instead of propagating the GoogleApiClientException (or any GoogeApiClient errors, for that matter), it could just disable AndroidPay, and the credit card and PayPal would remain usable as payment methods. Currently, when opening the Drop In, I immediately get back onActivityResult() with resultCode = 1, which is not ideal.

@lkorth
Copy link
Member

lkorth commented Feb 21, 2017

@mrsasha Thanks for the report and information! We have a fix that will go into the next release.

@mrsasha
Copy link
Author

mrsasha commented Mar 13, 2017

Hi, any info on the ETA of the next release?

@lkorth
Copy link
Member

lkorth commented Mar 13, 2017

Thanks for your patience @mrsasha, we have been waiting on another change in https://github.com/braintree/braintree_android. This fix will go out this week.

@mrsasha
Copy link
Author

mrsasha commented Mar 14, 2017

cool, thanks!

@lkorth lkorth closed this as completed in d37e32d Mar 24, 2017
@lkorth
Copy link
Member

lkorth commented Mar 25, 2017

The fix for this was released in 3.0.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants