Skip to content
This repository has been archived by the owner on May 21, 2020. It is now read-only.

The findInputs method is killing IE7 #7

Closed
wants to merge 1 commit into from
Closed

The findInputs method is killing IE7 #7

wants to merge 1 commit into from

Conversation

SamBenson
Copy link

I've noticed that the findInputs method is throwing a fatal error in IE7 when the form it's called on has direct children which aren't inputs.

For example: we're using Twitter Bootstrap which calls for the following type of structure...

<form class="form-horizontal">
    <div class="control-group">
        <label class="span2 control-label">Card Number</label>

        <div class="preSpan2 controls">
            <input class="span5 cardNumber" type="text" autocomplete="off" data-encrypted-name="number" />
        </div>
    </div>
</form>

When you submit the form in IE7 you get Unable to get value of the property 'data-encrypted-name': object is null or undefined.

@cosgroveb
Copy link
Member

Hey Sam,

Thanks for the contribution and sorry for the trouble your users have run into with IE7. We'll take a look this week and see if we can merge in your change.

@SamBenson
Copy link
Author

No problem - thanks for the fast reply!

@braintreeps
Copy link
Contributor

Hi @SamBenson,

Just wanted to say thanks again for your contribution and raising this issue. We've released a fix that should address the error you found in IE 7.

Please report back if you experience any other troubles.

@braintreeps braintreeps closed this Jun 6, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants