Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing translation and CSS bug #134

Closed
MrMooky opened this issue Apr 24, 2017 · 1 comment · Fixed by #135
Closed

Missing translation and CSS bug #134

MrMooky opened this issue Apr 24, 2017 · 1 comment · Fixed by #135

Comments

@MrMooky
Copy link

MrMooky commented Apr 24, 2017 •
edited

General information

  • SDK/Library version: 1.0.0 Beta 6
  • Environment: Sandbox
  • Browser and OS Chrome 57.0.2987.133 (64-bit)) on MacOS 10.12.4

Issue description

Screenshot:

screen shot 2017-04-24 at 10 47 10 am

Both issues are visible in the screenshot:

  • Translation is not correct. The DropIn-UI is set to de_DE (works fine for the other parts)
  • CSS is buggy. Element has a max-width of 148px, but the main container is larger by default
crookedneighbor added a commit that referenced this issue Apr 24, 2017
@crookedneighbor
Set PayPal button to be translatable
5036ea2 
closes #134
@crookedneighbor crookedneighbor mentioned this issue Apr 24, 2017
Merged
2 tasks
@crookedneighbor
Copy link
Contributor

Thanks for reporting.

The translation issue will be fixed in #135

The max-width issue looks to me like a duplicate of #86

crookedneighbor added a commit that referenced this issue Apr 27, 2017
@crookedneighbor
Set PayPal button to be translatable (#135)
5125b52 
* Set PayPal button to be translatable

closes #134

* Add CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set PayPal button to be translatable braintree/braintree-web-drop-in
2 participants
@crookedneighbor @MrMooky