-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Container input support #159
Comments
We decided not to support it in order to simplify the API. Can you explain why your integration depends on it? Does the element not have an id property you can leverage? IE: braintree.dropin.create({
authorization: auth,
selector: '#' + myDomNode.id
}, callback); |
We're using Braintree in an Angular component, so the most obvious way to access the intended DOM node is as a descendant of the root of the component. Although, now that I think about it, while it's a bit of a hack, we can just generate a random GUID and set it as the ID to use for the selector. |
This was released in version 1.1.0 |
I was skimming some of the source code in lieu of documentation (see #158), when I noticed this: https://github.com/braintree/braintree-web-drop-in/blob/182bd39/src/dropin.js#L47
In Braintree v2, directly passing in
container
with a DOM element was supported (and my existing code depends on this). Would you be willing to add that option back in this module?The text was updated successfully, but these errors were encountered: