Add ability to pass in a DOM Node to Drop-in creation #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilaconlee
approved these changes
May 15, 2017
src/dropin.js
Outdated
| callback(new DropinError('options.selector is required.')); | ||
| callback(new DropinError('options.selector or options.container are required.')); | ||
| return; | ||
| } else if (selector && container) { |
There was a problem hiding this comment.
Is this better than picking one by default? I could go either way.
quinnjn
approved these changes
May 15, 2017
skunkworks
reviewed
May 15, 2017
Conflicts: README.md
Conflicts: CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some frameworks don't give you easy access to css selectors for the dom nodes where drop-in will be inserted. This allows people to pass in a
containerproperty instead of selector which will be the DOM Node to pass Drop-in into.We could overload
selectorand allow it to take a DOM Node or a CSS selector, but I thought it would be a weird API for prop named selector to take a DOM Node directly.Closes #159
Checklist