Missing proguard rules for Visa Checkout

[RadoslawHardyl]

Hey guys,
We're using latest SDK ver. 2.5.1, and we cannot build versions with proguard enabled.

Warnings:

Warning:com.braintreepayments.api.VisaCheckout: can't find referenced class com.visa.checkout.PurchaseInfo$PurchaseInfoBuilder
Warning:com.braintreepayments.api.VisaCheckout: can't find referenced class com.visa.checkout.VisaCheckoutSdk
Warning:com.braintreepayments.api.VisaCheckout: can't find referenced class com.visa.checkout.VisaPaymentSummary
Warning:com.braintreepayments.api.VisaCheckout: can't find referenced class com.visa.checkout.Profile$ProfileBuilder
Warning:com.braintreepayments.api.VisaCheckout: can't find referenced class com.visa.checkout.PurchaseInfo$PurchaseInfoBuilder
Warning:com.braintreepayments.api.VisaCheckout: can't find referenced class com.visa.checkout.Profile
Warning:com.braintreepayments.api.VisaCheckout: can't find referenced class com.visa.checkout.PurchaseInfo
Warning:com.braintreepayments.api.VisaCheckout: can't find referenced class com.visa.checkout.Profile$ProfileBuilder
Warning:com.braintreepayments.api.VisaCheckout: can't find referenced class com.visa.checkout.PurchaseInfo$PurchaseInfoBuilder
Warning:com.braintreepayments.api.VisaCheckout: can't find referenced class com.visa.checkout.VisaPaymentSummary
Warning:com.braintreepayments.api.VisaCheckout$1: can't find referenced class com.visa.checkout.Environment
Warning:com.braintreepayments.api.VisaCheckout$1: can't find referenced class com.visa.checkout.Profile$ProfileBuilder
Warning:com.braintreepayments.api.VisaCheckout$1: can't find referenced class com.visa.checkout.Profile$DataLevel
Warning:com.braintreepayments.api.VisaCheckout$1: can't find referenced class com.visa.checkout.Profile$ProfileBuilder
Warning:com.braintreepayments.api.VisaCheckout$1: can't find referenced class com.visa.checkout.Profile
Warning:com.braintreepayments.api.VisaCheckout$1: can't find referenced class com.visa.checkout.Profile$ProfileBuilder
Warning:com.braintreepayments.api.models.VisaCheckoutBuilder: can't find referenced class com.visa.checkout.VisaPaymentSummary
Warning:com.braintreepayments.api.models.VisaCheckoutConfiguration: can't find referenced class com.visa.checkout.Profile$CardBrand
Warning:com.braintreepayments.api.models.VisaCheckoutConfiguration: can't find referenced class com.visa.checkout.Profile
Warning:there were 33 unresolved references to classes or interfaces.
Warning:Exception while processing task java.io.IOException: Please correct the above warnings first.

Looks like proguard rules for Visa Checkout are missing.
According to Visa docs we added:

-dontwarn com.visa.** -keep class com.visa.** { *; }

Could you add this in next release?(maybe something more is missing for Visa)

PS. Maybe it would be reasonable to move Visa Checkout to another module?
Because not everyone will use it:) and other SDK resources will merge correctly(like Visa Manifest)

Best Regars

[lkorth]

Thanks for the report! I've updated the consumer proguard file in Braintree and tested that the warnings are correctly handled.

This will go out in the next release, in the meantime -dontwarn com.visa.** is enough to suppress these warnings.

None of the numerous Visa Checkout dependencies are included in the Braintree module, but it does reference classes in them which is where these warnings are coming from.