Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ThreeDSecureV1UiCustomization doesn't support accented characters #288

Closed
calvarez-ov opened this issue Jan 27, 2020 · 2 comments
Closed

Comments

@calvarez-ov
Copy link

calvarez-ov commented Jan 27, 2020

General information

  • SDK/Library version: 3.8.0
  • Environment: Sandbox
  • Android Version and Device: Android 9, Galaxy S9
  • Braintree dependencies:
    • com.braintreepayments.api:braintree:3.8.0
    • com.braintreepayments.api:three-d-secure:3.8.0
    • com.braintreepayments.api:drop-in:4.5.0

Issue description

val threeDSecuireUiCustomization = ThreeDSecureV1UiCustomization().apply {
    redirectButtonText("CLICK HERE")
    redirectDescription("Some téxt with accéntéd chàractèrs")
}
val request = ThreeDSecureRequest().apply {
    versionRequested(ThreeDSecureRequest.VERSION_2)
    nonce(nonce)
    amount(amount)
    email("me@me.com")
    mobilePhoneNumber("+33123456789")
    billingAddress(postalAddress)
    additionalInformation(ThreeDSecureAdditionalInformation().shippingAddress(postalAddress))
    v1UiCustomization(threeDSecuireUiCustomization)
}
ThreeDSecure.performVerification(fragment, request) {...}

Expected behavior: After the user enters the 3ds code, the user should see the page with the big blue button with label "CLICK HERE" and explanation text "Some téxt with accéntéd chàractèrs"

Actual behavior:
404 not found error

Note: the expected behavior is seen if we don't include any accented characters in the button label or description. The buggy behavior is seen if either the button label or the description contain accented characters.

@sestevens
Copy link
Contributor

@calvarez-ov Thanks for reporting this. We're able to reproduce the issue, and we're currently working to resolve it. We'll update here once we have a fix.

billwerges pushed a commit that referenced this issue Feb 20, 2020
* Fix bug where 3DS1 browser switch didn't handle accented characters correctly in the redirect button and description (resolves issue #288)
@sestevens
Copy link
Contributor

@calvarez-ov This bug should be resolved in version 3.9.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants