[main] Bump to Magnes v5.5.0 #1217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ile exists in App Archive
Co-authored-by: Sammy Cannillo <scannillo@paypal.com>
scannillo
commented
Mar 12, 2024
| @@ -1,6 +1,6 @@ | |||
| #if 0 | |||
| #elif defined(__arm64__) && __arm64__ | |||
| // Generated by Apple Swift version 5.8 (swiftlang-5.8.0.124.2 clang-1403.0.22.11.100) | |||
| // Generated by Apple Swift version 5.7.1 (swiftlang-5.7.1.135.3 clang-1400.0.29.51) | |||
There was a problem hiding this comment.
I think this is fine since it's backward compatible with merchant apps that may use newer Swift versions. Please call out if you disagree!
There was a problem hiding this comment.
I wonder if this will be an issue with this upcoming requirement - https://developer.apple.com/news/upcoming-requirements/?id=04292024a. I don't think so, but good to discuss
There was a problem hiding this comment.
I don't think it should be an issue as long as it works currently. It looks like Xcode 15 supports down to Swift 4
jaxdesmarais
approved these changes
Mar 13, 2024
| @@ -1,6 +1,6 @@ | |||
| #if 0 | |||
| #elif defined(__arm64__) && __arm64__ | |||
| // Generated by Apple Swift version 5.8 (swiftlang-5.8.0.124.2 clang-1403.0.22.11.100) | |||
| // Generated by Apple Swift version 5.7.1 (swiftlang-5.7.1.135.3 clang-1400.0.29.51) | |||
There was a problem hiding this comment.
I don't think it should be an issue as long as it works currently. It looks like Xcode 15 supports down to Swift 4
warmkesselj
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Checklist
Authors
@scannillo