Include tests in release #136
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is not going to do what you want it to do. The unit tests may be able to run under that system, but the integration tests will always fail as they rely on a specific version of the Braintree API that runs in development. |
|
So what would you advise to run if we want to ensure that the installed package is working correctly? |
|
I don't have any advice. I'm not familiar with the practices of the system y'all are using. I just know that the integration tests in this repo will never pass upstream on your system, so it doesn't accomplish what you want it to. I'm going to close this for now, but happy to continue the conversation if you have thoughts about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will be useful to have the tests included in the release archive published, this will help packager to ensure the package installation is correctly working by executing the tests (see https://bugs.gentoo.org/767256).