Tidy up

[petecraven91]

Refactored the code so it isn't all in one file. broke out functions and the card types

[crookedneighbor]

Overall, I think it's a good move to split this large file into several smaller files, but I have a bunch of nitpicks I think should be addressed.

In addition, if we're pulling many of these things into units, now is probably the time to unit test those functions rather than treating them as private functions of the main module. If you do not want to do that work, we'll do that before merging in.

[crookedneighbor]

I don't think it's necessary to have all these nested inside a helpers directory.

[petecraven91]

@crookedneighbor all valid points. I've made the suggested changes
I agree this is the ideal time to add testing for each function, just don't have the time to do it right now but can look at doing this for future pull requests

[crookedneighbor]

Changes look great.

I just noticed that you have the file names in camel case. Braintree's normal style is to have file names in kebab case (lib/card-types.js). Can you make that change?

[petecraven91]

Thanks
Updated to kebab case

[jackellenberger]

Looks good to me! @crookedneighbor do you have thoughts vis a vis declaring a function then module.exports = function vs module.exports = function () { }?

[crookedneighbor]

I don't care that much.

Usually, if it's a small function, all I'll just do: module.exports = function () {} and if it's longer, I'll name it.

[crookedneighbor]

Will work on adding some additional tests for this on Friday.

[crookedneighbor]

Didn't get a chance to work on this last week like I'd hoped. Will try to get this merged in this week.

[crookedneighbor]

Merged in with 32c92e9

Made a few choices to combine some files. For instance, the matchesPattern and matchesRange functions could be considered private methods of the matches module, so I moved them in there and made sure to test both cases in the test file for matches.

Thanks for doing this chore!