Add Live Demo #92
Closed
Add Live Demo #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Live demo link
|
@KimGenius Thanks for the thoughtful demo and PR! This seems like a great idea, we'll review the demo and see what is the best path forward for linking to live demos. |
|
I like the idea of adding a demo, but I think it should: A) be presented in this repo through Github Pages so it can be reached at https://braintree.github.io/credit-card-type B) be framework agnostic, not specifically React |
|
Going to close this for now, but if you'd like to submit a new PR that meets the criteria I laid out, go for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Thank you so much to made good library
I think so this library need Live Demo code link in README !
So, i made Live Demo with Code sandbox
If you think like me, please merge this pull request!
Thank you!