This repository has been archived by the owner on Apr 18, 2018. It is now read-only.
Data store instances #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… DataStore agnostic
…stored per instance rather than on the class
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it would be better to instantiate data stores rather than have class methods with state stored on the class. As one example of why: right now it would be impossible to connect to multiple Mongo databases with Curator. I think getting rid of the class methods will also allow us to simplify testing setup, removing the need for with_config and the calls to data_store.instance_variable_set(:@client, nil) in the mongo specs. If this change is pulled in, I'll follow up with some additional commits to clean those things up.
This branch includes the commit from the dan-manges:find_by_index_rename branch. If necessary, I can implement this branch independently of that commit.