Add tests to verify the behavior of disable_ddl_transaction #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkrage
force-pushed
the
disable-ddl-transaction-tests
branch
from
67fcb65
to
abeb752
Compare
rkrage
commented
Jun 6, 2024
|
|
||
| subclass.suppress_messages do | ||
| expect(subclass.new.unsafe_pg_ha_migrations_test_method).to eq("sentinel_value") | ||
| end |
There was a problem hiding this comment.
I just noticed a bunch of this in the test output:
-- pg_ha_migrations_test_method(nil)
-> 0.0001s
jcoleman
reviewed
Jun 14, 2024
| aggregate_failures do | ||
| expect do | ||
| migration_klass.suppress_messages do | ||
| ActiveRecord::MigrationContext.new( |
There was a problem hiding this comment.
Can we add comments explaining that our usually way of testing doesn't invoke ActiveRecord's transaction handingling?
rkrage
force-pushed
the
disable-ddl-transaction-tests
branch
from
d9091a3
to
b36942f
Compare
Done and done |
rkrage
force-pushed
the
disable-ddl-transaction-tests
branch
from
b36942f
to
51402cb
Compare
jcoleman
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With recent PRs / conversations around transactional migrations, I figured it would be a good idea to write some basic tests to verify existing behavior. In other tests, we execute test migrations directly which bypasses the transaction logic in AR.