Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix decompression failed in nodejs #65

Closed
wants to merge 1 commit into from

Conversation

GuanJdoJ
Copy link

@GuanJdoJ GuanJdoJ commented Jun 9, 2024

#63

Copy link

vercel bot commented Jun 9, 2024

@GuanJdoJ is attempting to deploy a commit to the BrainTrustData Team on Vercel.

A member of the Team first needs to authorize it.

@ankrgyl
Copy link
Contributor

ankrgyl commented Jun 19, 2024

I am working on a change that fixes this, among a few other things, more comprehensively. The change you made is close, but does not work for certain platforms (e.g. workerd) which do not decompress fetch results automatically.

Here's the fix: https://github.com/braintrustdata/braintrust-proxy/pull/68/files#diff-f9467ab4882d85829b5ae101d098958cb1f6dafcb726ed6baee1dc26a5e34e9bR300

If you want to port this logic into an independent change here, happy to review that, otherwise we will land the larger change in the next few days.

@ankrgyl
Copy link
Contributor

ankrgyl commented Jun 29, 2024

Going to close this out since this functionality has been upstreamed.

@ankrgyl ankrgyl closed this Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants