Skip to content

Commit

Permalink
Some minor findings from code inspection.
Browse files Browse the repository at this point in the history
  • Loading branch information
guelzow committed May 9, 2018
1 parent 6c6bba5 commit 9341727
Show file tree
Hide file tree
Showing 8 changed files with 15 additions and 14 deletions.
2 changes: 1 addition & 1 deletion Classes/Plugins/AimeosMagic/Callbacks/ThroughMethods.php
Expand Up @@ -68,4 +68,4 @@ public function callMe()

return $result;
}
}
}
1 change: 0 additions & 1 deletion Classes/Plugins/AimeosMagic/Configuration.php
Expand Up @@ -73,6 +73,5 @@ public static function exec()
'Brainworxx\\Krexx\\Analyse\\Callback\\Analyse\\Objects\\Methods::callMe::start',
'Brainworxx\\Includekrexx\\Plugins\\AimeosMagic\\EventHandlers\\Methods'
);

}
}
16 changes: 10 additions & 6 deletions Classes/Plugins/AimeosMagic/EventHandlers/Methods.php
Expand Up @@ -39,7 +39,11 @@
use Brainworxx\Krexx\Service\Factory\EventHandlerInterface;
use Brainworxx\Krexx\Service\Factory\Pool;


/**
* Resolving Aimeos magical decorator class methods.
*
* @package Brainworxx\Includekrexx\Plugins\AimeosMagic\EventHandlers
*/
class Methods implements EventHandlerInterface
{
/**
Expand Down Expand Up @@ -82,18 +86,18 @@ class Methods implements EventHandlerInterface
/**
* Inject the pool.
*
* @param \Brainworxx\Krexx\Service\Factory\Pool $pool
* @param Pool $pool
*/
public function __construct(\Brainworxx\Krexx\Service\Factory\Pool $pool)
public function __construct(Pool $pool)
{
$this->pool = $pool;
}

/**
* Resolving the possible methods from the decorator pattern.
*
* @param array $params
* The parameters from the analyse class
* @param AbstractCallback $callback
* The original callback.
* @param \Brainworxx\Krexx\Analyse\Model|null $model
* The model, if available, so far.
*
Expand Down Expand Up @@ -278,4 +282,4 @@ protected function retreivePublicMethods(\ReflectionClass $ref)

return $result;
}
}
}
2 changes: 1 addition & 1 deletion Classes/Plugins/AimeosMagic/EventHandlers/Properties.php
Expand Up @@ -58,7 +58,7 @@ public function callMe()
* We add our magical properties right before the normal
* public properties.
*
* @param AbstractCallback $params
* @param AbstractCallback $callback
* The calling class.
* @param \Brainworxx\Krexx\Analyse\Model|null $model
* The model, if available, so far.
Expand Down
Expand Up @@ -65,7 +65,7 @@ public function __construct(Pool $pool)
}

/**
* @param AbstractCallback $params
* @param AbstractCallback $callback
* The calling class.
* @param \Brainworxx\Krexx\Analyse\Model|null $model
* The model, if available
Expand Down
Expand Up @@ -65,7 +65,7 @@ public function __construct(Pool $pool)
/**
* We simply remove the 'get' from the method name in the model.
*
* @param AbstractCallback $params
* @param AbstractCallback $callback
* The calling class.
* @param \Brainworxx\Krexx\Analyse\Model|null $model
* The model so far.
Expand Down
2 changes: 1 addition & 1 deletion Classes/Plugins/FluidDebugger/EventHandlers/VhsMethods.php
Expand Up @@ -67,7 +67,7 @@ public function __construct(Pool $pool)
* We set the multiline code generation to VHS, and We add the name of the
* parameter for the VHS code generation into the 'paramArray'
*
* @param AbstractCallback $params
* @param AbstractCallback $callback
* The calling class.
* @param \Brainworxx\Krexx\Analyse\Model|null $model
* The model so far.
Expand Down
2 changes: 0 additions & 2 deletions class.ext_update.php
Expand Up @@ -32,7 +32,6 @@
* Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
*/

use TYPO3\CMS\Core\Utility\ExtensionManagementUtility;
use TYPO3\CMS\Core\Utility\GeneralUtility;

/**
Expand Down Expand Up @@ -62,5 +61,4 @@ public function main()
GeneralUtility::makeInstance('TYPO3\\CMS\\Core\\Cache\\CacheManager')
->flushCachesInGroup('system');
}

}

0 comments on commit 9341727

Please sign in to comment.