Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVE-2007-4559 Patch #66

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
24 changes: 23 additions & 1 deletion backend/src/baserow/core/management/backup/backup_runner.py
Expand Up @@ -109,7 +109,29 @@ def restore_baserow(

with tempfile.TemporaryDirectory() as temporary_directory_name:
with tarfile.open(backup_file_name, "r:gz") as backup_input_tar:
backup_input_tar.extractall(temporary_directory_name)

import os

def is_within_directory(directory, target):

abs_directory = os.path.abspath(directory)
abs_target = os.path.abspath(target)

prefix = os.path.commonprefix([abs_directory, abs_target])

return prefix == abs_directory

def safe_extract(tar, path=".", members=None, *, numeric_owner=False):

for member in tar.getmembers():
member_path = os.path.join(path, member.name)
if not is_within_directory(path, member_path):
raise Exception("Attempted Path Traversal in Tar File")

tar.extractall(path, members, numeric_owner)


safe_extract(backup_input_tar, temporary_directory_name)

backup_internal_folder_name = Path(backup_file_name).name
backup_sub_folder = Path(
Expand Down