Adding support for frame data extraction into ffprobe command. #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like https://johnvansickle.com/ffmpeg/releases/ffmpeg-release-64bit-static.tar.xz doesn't exist anymore (404). This is why the travis build is failing. Weren't my code, guv, honest! |
|
I super-duper want this pretty please! |
|
Can we merge this? |
|
Can we please add this change |
|
Sorry for the slow response. This change looks great. No comments, other than it now seems to have some simple merge conflicts. Please could you take a look. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also supports requirement mentioned in #138.
In this version
-show_framesis included in the ffprobe command, and frame data is extracted and deserialised. This is accomplished by a newFFmpegFrameDeserializerclass, which supports polymorphism in the frame types.