Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hue Fair Ceiling/Pendant LUT; Add Tasmota Measure Script #118

Merged
merged 6 commits into from
Aug 26, 2021
Merged

Add Hue Fair Ceiling/Pendant LUT; Add Tasmota Measure Script #118

merged 6 commits into from
Aug 26, 2021

Conversation

stefangries
Copy link
Contributor

No description provided.

@stefangries stefangries changed the title Add Hue Fair Ceiling/Pendant LUT Add Hue Fair Ceiling/Pendant LUT; Add Tasmota Measure Script Aug 26, 2021
@bramstroker
Copy link
Owner

Thanks for PR and the Tasmota measure script (this will also be helpfull for others).

Could you please format the JSON? It is still valid json but not really readable because it's on one line.

@stefangries
Copy link
Contributor Author

Done 👍

@bramstroker
Copy link
Owner

I have checked LTC002, and I see there are some 0.1 - 0.3 measurements which are lower than standby usage. This will highly likely be inaccuracies of power meter on very low power values, which most power meters have problems with.
Did you measure standby usage or just set it to 0.4?
Also I see you "only" have 315 measurements. How long did it take to do these measurements?
Some steps in color temperature will result in a 5 watt difference (which is quite a lot). Currently the component will not interpolate, maybe I will add this in the future. So when you select for example mired 230 the component will show 20.03, when the actual value is more likely to be 18.

201,213,15.67
201,243,20.03

Above remarks are no huge deal, and I am happy to merge this at current state. But I would prefer to have a more granular CSV file (with 1000 measurements) when it does not take to much time and effort.

@stefangries
Copy link
Contributor Author

I have checked LTC002, and I see there are some 0.1 - 0.3 measurements which are lower than standby usage. This will highly likely be inaccuracies of power meter on very low power values, which most power meters have problems with.
Did you measure standby usage or just set it to 0.4?

All values are automatically generated by the script. So yes - apparently the meter is inaccurate.

Also I see you "only" have 315 measurements. How long did it take to do these measurements?

To be honest, I don't know. I didn't design the script completely, I just modified measure_kasa.py to address Tasmota_Plugs instead of TP-Link plugs. I had assumed that this script would also set the number of measurements correctly.

Some steps in color temperature will result in a 5 watt difference (which is quite a lot). Currently the component will not interpolate, maybe I will add this in the future. So when you select for example mired 230 the component will show 20.03, when the actual value is more likely to be 18.

Okay, interpolation would be nice.

Above remarks are no huge deal, and I am happy to merge this at current state. But I would prefer to have a more granular CSV file (with 1000 measurements) when it does not take to much time and effort.

To be honest: The Hue Fair lights are permanently mounted on the ceiling. I took one down to measure this. Unfortunately, I have already mounted it again. If it can be avoided, I would like to refrain from removing the luminaire again.

@bramstroker
Copy link
Owner

Also I see you "only" have 315 measurements. How long did it take to do these measurements?

To be honest, I don't know. I didn't design the script completely, I just modified measure_kasa.py to address Tasmota_Plugs instead of TP-Link plugs. I had assumed that this script would also set the number of measurements correctly.

This measure script measure_kasa.py was copied by another contributer from the original measure.py script, but the amount of measure points was changed (did not saw that before). Will do some restructuring on the measure scripts soon to get rid of all the duplicated code.

Some steps in color temperature will result in a 5 watt difference (which is quite a lot). Currently the component will not interpolate, maybe I will add this in the future. So when you select for example mired 230 the component will show 20.03, when the actual value is more likely to be 18.

Okay, interpolation would be nice.

Yes there is already a issue for this #92, I did some work on it 2 weeks ago, but still have to finish it.

Above remarks are no huge deal, and I am happy to merge this at current state. But I would prefer to have a more granular CSV file (with 1000 measurements) when it does not take to much time and effort.

To be honest: The Hue Fair lights are permanently mounted on the ceiling. I took one down to measure this. Unfortunately, I have already mounted it again. If it can be avoided, I would like to refrain from removing the luminaire again.

No problem we leave it this way. Will change the default measure scripts to take more measurements.

Thanks for your efforts.

@bramstroker bramstroker merged commit 786349a into bramstroker:master Aug 26, 2021
@nepozs
Copy link
Contributor

nepozs commented Aug 27, 2021

I think there sholud be noted in description, that in this case LUT file contains small count of samples.

@bramstroker
Copy link
Owner

Hi @stefangries. Last days I worked on new measure script. See #141. Took the two concepts (powermeter, light controller) and made them easily interchangable. Also to get rid of all the duplicated code. So you can use the HA api to control the lights, and direct Tasmota API to get the power reading for example.
Ported your Tasmota implementation to be included in the new script, but I have no way to test it. Could you please have a look and let me know if it works correctly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants