Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readd LightZone (MeLiTec) DP15 #1188

Merged
merged 1 commit into from Nov 4, 2022
Merged

Readd LightZone (MeLiTec) DP15 #1188

merged 1 commit into from Nov 4, 2022

Conversation

RubenKelevra
Copy link
Contributor

I've fixed the floating point numbers in the mired row. @bramstroker please report back if it's now valid :)

Fixes #1073

New supersedes #805

@bramstroker wrote:

There are rows like this, which is incorrect. brightness and color temp needs to be integers, but there are only 2 columns instead of 3 and the first column is a float.

Hm the file has floats for some reason in the mired row... but I haven't found a row with just "2 columns instead of 3".

@RubenKelevra
Copy link
Contributor Author

Woopsi, fixed :)

@bramstroker
Copy link
Owner

hmm very strange error during running the unit tests.

Screenshot 2022-10-28 at 19 04 05

I don't see it yet, because this constant MANUFACTURER_MELITECH is actually defined in aliases.py, so I don't see why it would raise an error on it.

@bramstroker
Copy link
Owner

I see, it's because you have added the same key twice now. Could you please correct that?

Screenshot 2022-10-28 at 19 09 17

@RubenKelevra
Copy link
Contributor Author

I see, it's because you have added the same key twice now. Could you please correct that?

Screenshot 2022-10-28 at 19 09 17

Woops. Strange that the automated check found the one duplication but not the other one. 😅

@RubenKelevra RubenKelevra marked this pull request as draft November 4, 2022 09:41
@coveralls
Copy link

coveralls commented Nov 4, 2022 •
edited

Pull Request Test Coverage Report for Build 3392758866

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.578%
Totals Coverage Status
Change from base Build 3392696442: 0.0%
Covered Lines: 2578
Relevant Lines: 2642
💛 - Coveralls

@RubenKelevra
Copy link
Contributor Author

RubenKelevra commented Nov 4, 2022 •
edited

@bramstroker Fixed and squashed into one commit :)

@RubenKelevra RubenKelevra marked this pull request as ready for review November 4, 2022 09:44
@sonarcloud
Copy link

sonarcloud bot commented Nov 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bramstroker
Copy link
Owner

Thanks @RubenKelevra

@bramstroker bramstroker merged commit 7100e38 into bramstroker:master Nov 4, 2022
@RubenKelevra RubenKelevra deleted the readd_LightZone_DP15 branch April 21, 2023 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

invalid literal for int with base 10 (lut sensor)
3 participants
@RubenKelevra @bramstroker @coveralls